[STF] Replace type_name implementation with cuda::std::__pretty_nameof wrapper#8194
Merged
caugonnet merged 3 commits intoNVIDIA:mainfrom Mar 27, 2026
Merged
[STF] Replace type_name implementation with cuda::std::__pretty_nameof wrapper#8194caugonnet merged 3 commits intoNVIDIA:mainfrom
caugonnet merged 3 commits intoNVIDIA:mainfrom
Conversation
…wrapper Remove the home-grown __PRETTY_FUNCTION__ parsing in traits.cuh and replace type_name<T> with a thin wrapper around cuda::std::__pretty_nameof<T>(), which is the existing robust CCCL facility for compile-time type name extraction. Made-with: Cursor
Contributor
andralex
approved these changes
Mar 26, 2026
Contributor
andralex
left a comment
andralex
left a comment
There was a problem hiding this comment.
Cool! Maybe it's worth removing type_name altogether and using __pretty_nameof as appropriate?
Contributor
Author
|
@andralex type_name returns a string_view and the operators that __pretty_nameof lack, and we can't really add such a method to get a string view to __pretty_nameof so I left it because it's indeed much more convenient. |
Contributor
Author
|
/ok to test 4354579 |
Contributor
🥳 CI Workflow Results🟩 Finished in 51m 58s: Pass: 100%/48 | Total: 21h 09m | Max: 42m 20s | Hits: 53%/25973See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the home-grown PRETTY_FUNCTION parsing in traits.cuh and replace type_name with a thin wrapper around cuda::std::__pretty_nameof(), which is the existing robust CCCL facility for compile-time type name extraction.
Description
closes
Checklist